fix(metrics): add rwx-volume-fast-failover to upgrade responder colle… #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-munson
requested review from
derekbit,
PhanLe1010,
c3y1huang and
ejweber
ejweber
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
LGTM.
As far as I can tell, this is all that is required. Let's wait for @PhanLe1010 to approve as well though, as he is much more of an expert in this area.
…ction Signed-off-by: James Munson <james.munson@suse.com>
james-munson
force-pushed
the
9347-fast-failver-metric
branch
from
c7b2789
to
623e987
Compare
innobead
approved these changes
Aug 31, 2024
|
@mergify backport v1.7.x |
✅ Backports have been created
|
|
We also need to update this file https://github.com/longhorn/longhorn/blob/master/deploy/upgrade_responder_server/chart-values.yaml . Could you please help @james-munson ? |
|
@PhanLe1010 wrote:
In longhorn PR longhorn/longhorn#9376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction
Which issue(s) this PR fixes:
longhorn/longhorn#9347
What this PR does / why we need it:
Add setting
rwx-volume-fast-failoverto the list collected for upgrade responder, so we can assess its adoption.Special notes for your reviewer:
Additional documentation or context