Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crd): update conversion webhook port to 9501 #3157

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9438

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Sep 11, 2024
@derekbit derekbit requested a review from a team as a code owner September 11, 2024 16:47
longhorn/longhorn crds.yaml is already updated.
Correct the port number to avoid any confusion.

Longhorn 9438

Signed-off-by: Derek Su <derek.su@suse.com>
@derekbit
Copy link
Member Author

derekbit commented Sep 13, 2024

Should be this one longhorn/longhorn#5590.
We changed the port from 9443 to 9501 in that ticket, but didn't update longhorn-manager crd patch files, so backport label seems not required.
It just makes the crds.yaml in longhorn and longhorn-manager consistent.

@derekbit derekbit merged commit 275f7ce into longhorn:v1.6.x Sep 13, 2024
6 checks passed
@shuo-wu
Copy link
Contributor

shuo-wu commented Sep 17, 2024

Just curious, when do we update this network policy ref doc? The doc already shows longhorn-conversion-webhook port 9501 several minor versions ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants