Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aggregate "*-dev-*" versions into single "dev" version #3177

Merged

Conversation

PhanLe1010
Copy link
Contributor

@PhanLe1010 PhanLe1010 commented Sep 25, 2024

This will prevent the upgrade responder from having too many tags which can be a performance issue

longhorn/longhorn#9522

@PhanLe1010 PhanLe1010 force-pushed the upgrade-check-exclude-dev-versions branch from 43b6c9e to a9d117f Compare September 25, 2024 02:11
@PhanLe1010 PhanLe1010 marked this pull request as ready for review September 25, 2024 02:20
derekbit
derekbit previously approved these changes Sep 25, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This will prevent the upgrade responder from having too many tags which
can be a performance issue

longhorn-9522

Signed-off-by: Phan Le <phan.le@suse.com>
@PhanLe1010 PhanLe1010 force-pushed the upgrade-check-exclude-dev-versions branch from a9d117f to df07db8 Compare September 25, 2024 02:29
@PhanLe1010 PhanLe1010 changed the title fix: do not send upgrade check requests if the current version is a dev version fix: aggregate "*-dev-*" versions into single "dev" version Sep 25, 2024
@PhanLe1010
Copy link
Contributor Author

@mergify backport v1.7.x, v1.6.x, v1.5.x

Copy link

mergify bot commented Sep 25, 2024

backport v1.7.x, v1.6.x, v1.5.x

❌ No backport have been created

  • Backport to branch v1.7.x, failed

GitHub error: Branch not found

  • Backport to branch v1.6.x, failed

GitHub error: Branch not found

@innobead innobead merged commit 8bc7575 into longhorn:master Sep 25, 2024
9 checks passed
@PhanLe1010
Copy link
Contributor Author

@mergify backport v1.7.x v1.6.x

Copy link

mergify bot commented Sep 25, 2024

backport v1.7.x v1.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants