Explicitly install libjson-c since nfs-ganesha requires it #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install whatever version of libjson-c is available since it changes between versions of bci-base. Longhorn 8166 Signed-off-by: Eric Weber <eric.weber@suse.com>
|
I tested this PR on top of the bad share-manager change, and it passed the regression tests. Looks good to me. |
innobead
approved these changes
Mar 19, 2024
|
Sounds good. Always calling out any implicit dependencies is important for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
We no longer need this to close out longhorn/longhorn#8166. However, @james-munson and I think we should still explicitly install libjson-c in during the share-manager image build since we discovered it was an implicit requirement. This has no effect while we still use bci-base:15.5, but it will probably keep us from running into issues with bci-base:15.6 when we eventually upgrade.