fix: golangci-lint error #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
innobead
requested changes
Apr 26, 2024
pkg/server/nfs/nfs_server.go
Outdated
| @@ -163,7 +163,9 @@ func getUpdatedGaneshConfig(config []byte) []byte { | |||
| LogPath: logPath, | |||
| } | |||
|
|
|||
| template.Must(template.New("Ganesha_Config").Parse(string(config))).Execute(&tmplBuf, tmplVals) | |||
| if err := template.Must(template.New("Ganesha_Config").Parse(string(config))).Execute(&tmplBuf, tmplVals); err != nil { | |||
| logrus.WithError(err).Fatal("Failed to parse ganesha config") | |||
There was a problem hiding this comment.
Let's return the error to let the caller handle instead of failing the program here.
There was a problem hiding this comment.
Since this function doesn't return error orginally, I update to log a warning message here. We can see whether to improve it if this error happens frequently.
Signed-off-by: PoAn Yang <poan.yang@suse.com>
innobead
approved these changes
Apr 26, 2024
|
@mergify backport v1.6.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#7448
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context