Test adjustment #118
Merged
Test adjustment #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuo-wu
previously approved these changes
Mar 5, 2024
|
This pull request is now in conflict. Could you fix it @DamiaSan? 🙏 |
|
The conflict is not resolved yet. Would you update the PR again? |
Vendor dependencies and spdk commit id of dapper dockerfile have been updated. Longhorn 7578 Signed-off-by: Damiano Cipriani <damiano.cipriani@suse.com>
Due to the introduction of lvol get xattr in go-spdk-helper, the duration of test's run is longer, so we have to increase the global timeout. Longhorn 7578 Signed-off-by: Damiano Cipriani <damiano.cipriani@suse.com>
If a global sync is performed, no flush command arrive to spdk. Instead, if for every volume a sync over the corresponding /dev/nvmeXnY is performed, the flush command is correctly received by spdk_tgt. Longhorn 7559 Signed-off-by: Damiano Cipriani <damiano.cipriani@suse.com>
shuo-wu
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #7578 , maybe #7559 #7810 #7697 #7693
What this PR does / why we need it:
With the introduction of lvol get xattr, the test need a greater timeout to be completed.
Moreover, the test exposed a strange behavior of the system when performing a global
syncbefore to make a snapshot. No flush command arrive to spdk and I/O errors start to happen in nvme kernel driver. We encounter also frequently disconnections/reconnections between nvme driver and spdk; with kernel version older thank 6.7, all of this lead to memory corruption inside nvme driver and so to system instability.However, I have to check better the reason of this strange behavior, but surely what I found is that with a
sync /dev/nvmeXnYthe problem disappear and that kernel 6.7 handle much better the errors in nvme driver.Special notes for your reviewer:
Additional documentation or context