Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(support-bundle): fix support-bundle agent test cases #1311

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix(support-bundle): fix support-bundle agent test cases #1311

merged 1 commit into from
Apr 19, 2023

Conversation

c3y1huang
Copy link
Collaborator

@c3y1huang c3y1huang commented Apr 14, 2023 •
edited
Loading

@c3y1huang c3y1huang self-assigned this Apr 14, 2023
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-toleration-node-count branch from 331575b to b532435 Compare April 17, 2023 05:39
@c3y1huang c3y1huang mentioned this pull request Apr 17, 2023
Closed
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-toleration-node-count branch 3 times, most recently from 1e9c474 to 3ddf1d0 Compare April 19, 2023 02:00
@c3y1huang c3y1huang marked this pull request as ready for review April 19, 2023 02:13
@c3y1huang c3y1huang requested a review from a team as a code owner April 19, 2023 02:13
@c3y1huang
Copy link
Collaborator Author

c3y1huang commented Apr 19, 2023 •
edited
Loading

The CI default-arm64/flake8 check is currently having an issue connecting to the Ubuntu server for package update/install. Will try again later. done

@c3y1huang c3y1huang mentioned this pull request Apr 19, 2023
Merged
@c3y1huang
fix(support-bundle): filtering wrong node list
1c52100 
Side effect of f20b52a. Should filter with Longhorn
nodes instead of K8s nodes.

Ref: 5614

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the fix-support-bundle-agent-toleration-node-count branch from 3ddf1d0 to 1c52100 Compare April 19, 2023 04:47
@innobead innobead merged commit f31e523 into longhorn:master Apr 19, 2023
@innobead
Copy link
Member

@Mergifyio backport v1.4.x

@mergify
Copy link

mergify bot commented Apr 19, 2023 •
edited
Loading

backport v1.4.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 19, 2023
Merged
@c3y1huang c3y1huang deleted the fix-support-bundle-agent-toleration-node-count branch April 19, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c3y1huang @innobead