test(negative): implement backupstore setup #1539

yangchiu · 2023-09-27T08:34:26Z

test: implement backupstore setup

(1) add backupstore.py for robot test cases
(2) only support s3 now, the subprocess parts in backupstore.py need to be refined to make nfs work
(3) fix wrong longorn client url issue when using it out-of-cluster (the same issue as #1300 (comment))

For longhorn/longhorn#6710

Signed-off-by: Yang Chiu yang.chiu@suse.com

innobead

Some feedback, but I didn't review all of them. Some need to be resolved first.

backupstore.py seems verbose and unstructured. I would suggest doing the below.

Use different Python modules to aggregate the related codes.

backupstore/__init__.py including all common functions for backupstore
backupstore/nfs.py
backupstore/minio.py (but actually it's s3)

Also, using the common naming (verb) for the function and method name instead, backupstore_cleanup should be changed to cleanup_backupstore and added to backupstore/__init__.py.

Please review the code and do the corresponding update.

e2e/libs/backupstore.py

yangchiu · 2023-10-04T09:14:50Z

Some feedback, but I didn't review all of them. Some need to be resolved first.

backupstore.py seems verbose and unstructured. I would suggest doing the below.

Use different Python modules to aggregate the related codes.
* backupstore/__init__.py including all common functions for backupstore
  backupstore/nfs.py
  backupstore/minio.py (but actually it's s3)
Also, using the common naming (verb) for the function and method name instead, backupstore_cleanup should be changed to cleanup_backupstore and added to backupstore/init.py.

Please review the code and do the corresponding update.

Refined to have class structure.

yangchiu · 2023-10-22T11:36:50Z

@longhorn/qa @innobead This PR is required to run negative test case Reboot Volume Node While Heavy Writing And Recurring Jobs Exist in v1.4.4 release test plan.

e2e/keywords/common.resource

e2e/libs/backupstore/base.py

e2e/libs/backupstore/minio.py

e2e/libs/backupstore/base.py

e2e/libs/backupstore/minio.py

c3y1huang

I assume most of the codes are moved from the integration tests as I see there are some variables that are still undefined, and the functions could be better organized. However, as long as the tests can run I think it's fine to merge this first and enhance later.

cc @innobead

mergify · 2023-10-27T06:27:27Z

This pull request is now in conflicts. Could you fix it @yangchiu? 🙏

e2e/libs/keywords/backupstore_keywords.py

outdated

e2e/libs/backupstore/base.py

e2e/libs/backupstore/minio.py

e2e/libs/recurringjob/rest.py

e2e/libs/utility/utility.py

(1) add backupstore.py for robot test cases (2) only support s3 now, the subprocess parts in backupstore.py need to be refined to make nfs work Signed-off-by: Yang Chiu <yang.chiu@suse.com>

resolved

e2e/libs/backupstore/minio.py

refined.

yangchiu requested review from innobead and a team September 27, 2023 08:34

yangchiu self-assigned this Sep 27, 2023

This was referenced Oct 1, 2023

[TEST] support nfs backupstore in robot test longhorn/longhorn#6819

Open

test: inject control plane node network latency #1542

Merged

innobead previously requested changes Oct 3, 2023

View reviewed changes

yangchiu force-pushed the backupstore branch from 6ff3fdd to 0e9c10a Compare October 4, 2023 09:04

yangchiu requested a review from innobead October 4, 2023 09:15

yangchiu requested a review from c3y1huang October 24, 2023 04:03

c3y1huang requested changes Oct 26, 2023

View reviewed changes

yangchiu force-pushed the backupstore branch 2 times, most recently from dbfbd7b to bddaaee Compare October 27, 2023 01:13

yangchiu requested a review from c3y1huang October 27, 2023 01:17

c3y1huang previously approved these changes Oct 27, 2023

View reviewed changes

c3y1huang force-pushed the backupstore branch from bddaaee to dee7656 Compare October 27, 2023 06:16

yangchiu dismissed c3y1huang’s stale review via 3acaa32 October 27, 2023 06:36

yangchiu force-pushed the backupstore branch from dee7656 to 3acaa32 Compare October 27, 2023 06:36

yangchiu requested a review from c3y1huang October 31, 2023 06:45

yangchiu enabled auto-merge November 17, 2023 05:43

yangchiu mentioned this pull request Nov 17, 2023

test(negative): implement force drain node #1599

Merged

yangchiu changed the title ~~test: implement backupstore setup~~ test(negative): implement backupstore setup Nov 17, 2023

yangchiu force-pushed the backupstore branch 4 times, most recently from b22e5ea to b1c1741 Compare February 6, 2024 03:23

yangchiu mentioned this pull request Feb 6, 2024

[BUG][v1.5.4-rc1] Recurring job failed to create/delete backups after node reboot longhorn/longhorn#7854

Closed

yangchiu force-pushed the backupstore branch from b1c1741 to 6d2321b Compare February 6, 2024 07:18

yangchiu force-pushed the backupstore branch 2 times, most recently from 36a5e11 to 26966bd Compare April 2, 2024 01:52

yangchiu requested review from a team and c3y1huang April 2, 2024 01:58

c3y1huang previously requested changes Apr 8, 2024

View reviewed changes

e2e/libs/keywords/backupstore_keywords.py Outdated Show resolved Hide resolved

yangchiu force-pushed the backupstore branch 3 times, most recently from dd64a57 to 7d5be6d Compare April 8, 2024 07:12

yangchiu requested review from c3y1huang and roger-ryao April 8, 2024 11:20

yangchiu force-pushed the backupstore branch from 7d5be6d to 2a4bac9 Compare April 9, 2024 04:22

c3y1huang previously requested changes Apr 10, 2024

View reviewed changes

e2e/libs/backupstore/base.py Outdated Show resolved Hide resolved

e2e/libs/backupstore/minio.py Outdated Show resolved Hide resolved

e2e/libs/recurringjob/rest.py Outdated Show resolved Hide resolved

e2e/libs/utility/utility.py Outdated Show resolved Hide resolved

yangchiu force-pushed the backupstore branch from 2a4bac9 to 39c61df Compare April 10, 2024 06:02

test: implement backupstore setup

37a88cd

(1) add backupstore.py for robot test cases (2) only support s3 now, the subprocess parts in backupstore.py need to be refined to make nfs work Signed-off-by: Yang Chiu <yang.chiu@suse.com>

yangchiu force-pushed the backupstore branch from 39c61df to 37a88cd Compare April 10, 2024 06:17

Merge branch 'master' into backupstore

cc95e9b

yangchiu requested review from c3y1huang and a team April 10, 2024 07:52

c3y1huang previously requested changes Apr 11, 2024

View reviewed changes

e2e/libs/backupstore/minio.py Outdated Show resolved Hide resolved

Merge branch 'master' into backupstore

850ea60

yangchiu force-pushed the backupstore branch from 7451716 to 850ea60 Compare April 11, 2024 02:50

yangchiu requested review from a team and c3y1huang April 11, 2024 03:27

c3y1huang approved these changes Apr 15, 2024

View reviewed changes

Merge branch 'master' into backupstore

d1f8cc8

auto-merge was automatically disabled April 15, 2024 01:24
Merge commits are not allowed on this repository

yangchiu merged commit 1d42c1c into longhorn:master Apr 15, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(negative): implement backupstore setup #1539

test(negative): implement backupstore setup #1539

yangchiu commented Sep 27, 2023

innobead left a comment •

edited

Loading

yangchiu commented Oct 4, 2023

yangchiu commented Oct 22, 2023

c3y1huang left a comment •

edited

Loading

mergify bot commented Oct 27, 2023

test(negative): implement backupstore setup #1539

test(negative): implement backupstore setup #1539

Conversation

yangchiu commented Sep 27, 2023

innobead left a comment • edited Loading

Choose a reason for hiding this comment

yangchiu commented Oct 4, 2023

yangchiu commented Oct 22, 2023

c3y1huang left a comment • edited Loading

Choose a reason for hiding this comment

mergify bot commented Oct 27, 2023

innobead left a comment •

edited

Loading

c3y1huang left a comment •

edited

Loading