Fix automated mirroring of livenessprobe #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 7428 Signed-off-by: Eric Weber <eric.weber@suse.com>
PhanLe1010
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
N/A
I discovered the issue while working on longhorn/longhorn#7428
What this PR does / why we need it:
The CSI mirroring scripts ignore images that aren't prefixed with
csi-orsupport-bundle-kit. However, we need to mirrorregistry.k8s.io/sig-storage/livenessprobein the same way asregistry.k8s.io/sig-storage/csi...images. My attempt to mirror a new version of livenessprobe (https://ci.longhorn.io/job/private/job/mirror-csi-images/16/) failed.Special notes for your reviewer:
I was surprised by the need to leave
csi-|livenessprobeunquoted, but according to both ShellCheck and my testing it is correct when pattern matching (https://www.shellcheck.net/wiki/SC2076).Additional documentation or context
It looks like this used to work in the environment variable case, but changes in #1625 broke it.