Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test case test_extra_replica_cleanup #1724

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

yangchiu
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#7936

What this PR does / why we need it:

Replace assertion with wait mechanism.

Special notes for your reviewer:

Additional documentation or context

Signed-off-by: Yang Chiu <yang.chiu@suse.com>
@yangchiu yangchiu requested review from innobead and a team February 16, 2024 01:30
@yangchiu yangchiu self-assigned this Feb 16, 2024
Copy link
Contributor

@roger-ryao roger-ryao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangchiu yangchiu merged commit 46cfe13 into longhorn:master Feb 16, 2024
4 of 5 checks passed
@yangchiu
Copy link
Member Author

@mergify backport v1.6.x v1.5.x v1.4.x

Copy link

mergify bot commented Feb 16, 2024

backport v1.6.x v1.5.x v1.4.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants