Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test case test_ha_backup_deletion_recovery #1827

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

roger-ryao
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#8231

What this PR does / why we need it:

Check if the backup volume exists and has been created before proceeding with the backing image synchronization check.
This addresses the case where the backup volume might not have been created yet.

Special notes for your reviewer:

Additional documentation or context

amd64 : https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6658/

arm64 : https://ci.longhorn.io/job/private/job/longhorn-tests-regression/6659

Screenshot_20240322_102156

@roger-ryao roger-ryao self-assigned this Mar 22, 2024
@roger-ryao roger-ryao requested a review from a team as a code owner March 22, 2024 02:27
@roger-ryao roger-ryao changed the title test: fix flaky test case test_ha_backup_deletion_recovery test: fix flaky test case test_ha_backup_deletion_recovery Mar 22, 2024
address the backup volume might not have been created yet

longhorn/longhorn#8231

Signed-off-by: Roger Yao <roger.yao@suse.com>
Copy link
Contributor

@chriscchien chriscchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangchiu yangchiu merged commit fdef8d2 into longhorn:master Mar 27, 2024
5 checks passed
@roger-ryao
Copy link
Contributor Author

@mergify backport v1.6.x v1.5.x

Copy link

mergify bot commented Mar 28, 2024

backport v1.6.x v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants