test(manual): support bundle node collection timeout #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longhorn/longhorn-8623 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-support-bundle-node-bundle-collection-timeout
branch
from
fcc519a
to
9d79fa5
Compare
| ``` | ||
| **And** A timeout log is recorded in the support bundle manager pod logs. | ||
| ``` | ||
| time="2024-05-28T03:07:07Z" level=info msg="Some nodes are timeout, not all node bundles are received." |
There was a problem hiding this comment.
Not related to this PR but just curious, can we print the node name also in the log? Or are we doing it already?
There was a problem hiding this comment.
When the node bundle is collected, the logs will include the node name:
time="2024-05-28T23:41:26Z" level=debug msg="Handle create node bundle for ip-10-0-1-238"
time="2024-05-28T23:41:26Z" level=debug msg="Complete node ip-10-0-1-238"
time="2024-05-28T23:41:26Z" level=debug msg="Complete node ip-10-0-1-185"
And, the support bundle also collects node CRs, which can be compared with the actual collected node bundles. So we should be able to work it out.
khushboo-rancher
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8623
What this PR does / why we need it:
Propose manually testing the support bundle node timeout to include a simulation of the node collection blockage with a patched image.
Special notes for your reviewer:
NoneAdditional documentation or context
rancher/support-bundle-kit#109