fix: attach volumes to eliminate duplicated replicas #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanYiLin
force-pushed
the
LH8573_fix_volume_creating_duplica_replicas_issues
branch
2 times, most recently
from
dc15f56
to
e5175e7
Compare
ref: longhorn/longhorn 8573 Signed-off-by: Jack Lin <jack.lin@suse.com>
ChanYiLin
force-pushed
the
LH8573_fix_volume_creating_duplica_replicas_issues
branch
from
e5175e7
to
3b2332a
Compare
|
@mergify backport v1.7.x v1.6.x |
✅ Backports have been created
|
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8573
longhorn/longhorn#8573 (comment)
When the engine image is not stable, there is a chance that the volume changes the owner and creates duplicated replicas.
This might fail this e2e test because it checks the number of replicas before the volume is attached.
We should attach the volume and let Longhorn deletes duplicated replicas before starting the test.