Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: restore test_rwx_delete_share_manager_pod expects no workload r… #2110

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

james-munson
Copy link
Contributor

@james-munson james-munson commented Sep 20, 2024

…estart

Which issue(s) this PR fixes:

longhorn/longhorn#9504

What this PR does / why we need it:

Restore change to test_rwx_delete_share_manager_pod that does not expect the workload pod(s) to be deleted.

Special notes for your reviewer:

Passed private run https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7623

test_rwx.py::test_rwx_with_statefulset_multi_pods PASSED
test_rwx.py::test_rwx_multi_statefulset_with_same_pvc PASSED
test_rwx.py::test_rwx_parallel_writing PASSED
test_rwx.py::test_rwx_statefulset_scale_down_up PASSED
test_rwx.py::test_rwx_delete_share_manager_pod PASSED
test_rwx.py::test_rwx_deployment_with_multi_pods PASSED
test_rwx.py::test_restore_rwo_volume_to_rwx[s3] PASSED
test_rwx.py::test_restore_rwo_volume_to_rwx[nfs] PASSED
test_rwx.py::test_rwx_online_expansion SKIPPED (TODO)
test_rwx.py::test_rwx_offline_expansion PASSED
test_rwx.py::test_encrypted_rwx_volume PASSED
test_rwx.py::test_rwx_volume_mount_options PASSED

Additional documentation or context

…estart

Signed-off-by: James Munson <james.munson@suse.com>
@james-munson james-munson requested a review from a team as a code owner September 20, 2024 17:54
@james-munson james-munson requested review from a team, yangchiu and khushboo-rancher and removed request for a team September 20, 2024 18:23
Copy link
Member

@yangchiu yangchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangchiu yangchiu merged commit 63349ad into longhorn:master Sep 23, 2024
5 of 6 checks passed
@james-munson
Copy link
Contributor Author

@mergify backport v1.7.x

Copy link

mergify bot commented Sep 23, 2024

backport v1.7.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants