Merge pull request #650 from yardenshoham/nicer

Make some of the delete confirmation dialogs nicer
longhorn · Oct 25, 2023 · edba105 · edba105
2 parents 1b2b2db + 92eb68c
commit edba105
Show file tree

Hide file tree

Showing 11 changed files with 12 additions and 12 deletions.
diff --git a/src/components/Replica/Replica.js b/src/components/Replica/Replica.js
@@ -19,7 +19,7 @@ class Replica extends React.Component {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete replica ${record.name} ?`,
+          title: `Are you sure you want to delete replica ${record.name}?`,
           onOk() {
             deleteReplicas([record])
           },

diff --git a/src/routes/backingImage/BackingImageActions.js b/src/routes/backingImage/BackingImageActions.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteBackingImage, cleanUpDiskMap, downloadBacking
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete backing image ${record.name} ?`,
+          title: `Are you sure you want to delete backing image ${record.name}?`,
           onOk() {
             deleteBackingImage(record)
           },

diff --git a/src/routes/engineimage/EngineImageActions.js b/src/routes/engineimage/EngineImageActions.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteEngineImage }) {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete engine image ${record.name} ?`,
+          title: `Are you sure you want to delete engine image ${record.name}?`,
           onOk() {
             deleteEngineImage(record)
           },

diff --git a/src/routes/host/DiskActions.js b/src/routes/host/DiskActions.js
@@ -16,7 +16,7 @@ function actions({ node, selected, updateDisk }) {
       }
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete disk which mounted on ${record.path}`,
+          title: `Are you sure you want to delete the disk that is mounted on ${record.path}?`,
           onOk() {
             const disks = Object.keys(node.disks)
               .filter(id => record.id !== id)

diff --git a/src/routes/host/HostActions.js b/src/routes/host/HostActions.js
@@ -13,7 +13,7 @@ function actions({ selected, showEditDisksModal, deleteHost }) {
         break
       case 'deleteHost':
         confirm({
-          title: `Are you sure you want to delete node ${selected.name} ?`,
+          title: `Are you sure you want to delete node ${selected.name}?`,
           onOk() {
             deleteHost(record)
           },

diff --git a/src/routes/host/ReplicaList.js b/src/routes/host/ReplicaList.js
@@ -9,7 +9,7 @@ function list({ dataSource, deleteReplicas, rowSelection }) {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete replica ${record.name} ?`,
+          title: `Are you sure you want to delete replica ${record.name}?`,
           onOk() {
             deleteReplicas([record])
           },

diff --git a/src/routes/orphanedData/orphanedDataActions.js b/src/routes/orphanedData/orphanedDataActions.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteOrphanedData }) {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete ${record.name} ?`,
+          title: `Are you sure you want to delete ${record.name}?`,
           width: 560,
           onOk() {
             deleteOrphanedData(record)

diff --git a/src/routes/recurringJob/RecurringJobActions.js b/src/routes/recurringJob/RecurringJobActions.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteRecurringJob, editRecurringJob }) {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete Recurring Job ${record.name} ?`,
+          title: `Are you sure you want to delete Recurring Job ${record.name}?`,
           content: <Alert
             description={`If the recurring job ${record.name} is the last one of a job group, Longhorn will remove the group from all volumes automatically.`}
             type="warning"

diff --git a/src/routes/systemBackups/systemBackupsAction.js b/src/routes/systemBackups/systemBackupsAction.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteSystemBackup, createSystemRestore }) {
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete System Backup ${record.name} ?`,
+          title: `Are you sure you want to delete System Backup ${record.name}?`,
           onOk() {
             deleteSystemBackup({ name: record.id })
           },

diff --git a/src/routes/volume/VolumeActions.js b/src/routes/volume/VolumeActions.js
@@ -94,7 +94,7 @@ function actions({
         break
       case 'rollback':
         confirm({
-          title: `Are you sure you want to rollback volume ${record.name} ?`,
+          title: `Are you sure you want to rollback volume ${record.name}?`,
           onOk() {
             rollback(record)
           },
@@ -141,7 +141,7 @@ function actions({
         break
       case 'trimFilesystem':
         confirm({
-          title: 'Are you sure you want to trim Fileystem ?',
+          title: 'Are you sure you want to trim the filesystem?',
           onOk() {
             trimFilesystem(record)
           },

diff --git a/src/routes/volume/detail/RecurringJobActions.js b/src/routes/volume/detail/RecurringJobActions.js
@@ -9,7 +9,7 @@ function actions({ selected, deleteVolumeRecurringJob, editRecurringJob, isGroup
     switch (event.key) {
       case 'delete':
         confirm({
-          title: `Are you sure you want to delete Recurring Job ${record.name} ?`,
+          title: `Are you sure you want to delete Recurring Job ${record.name}?`,
           onOk() {
             deleteVolumeRecurringJob(record)
           },