filter out volume in restoring or not ready status when bulk clone vo…

…lume Signed-off-by: andy.lee <andy.lee@suse.com>
longhorn · Jul 23, 2024 · fad0011 · fad0011
1 parent 1a660be
commit fad0011
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/routes/volume/VolumeBulkActions.js b/src/routes/volume/VolumeBulkActions.js
@@ -193,7 +193,8 @@ function bulkActions({
     { key: 'attach', name: 'Attach', disabled() { return selectedRows.length === 0 || selectedRows.some((item) => !attachable(item)) } },
     { key: 'detach', name: 'Detach', disabled() { return selectedRows.length === 0 || selectedRows.some((item) => !detachable(item)) } },
     { key: 'backup', name: 'Create Backup', disabled() { return selectedRows.length === 0 || isSnapshotDisabled() || hasDoingState() || isHasStandy() || hasVolumeRestoring() || !backupTargetAvailable }, toolTip: backupTargetMessage },
-    { key: 'bulkCloneVolume', name: 'Clone Volume', disabled() { return selectedRows.length === 0 } },
+    { key: 'bulkCloneVolume', name: 'Clone Volume', disabled() { return selectedRows.length === 0 || selectedRows.every(item => item.standby || isRestoring(item)) } },
+
   ]
 
   const allDropDownActions = [

diff --git a/src/routes/volume/index.js b/src/routes/volume/index.js
@@ -39,6 +39,7 @@ import UpdateReplicaAutoBalanceModal from './UpdateReplicaAutoBalanceModal'
 import UpdateBulkDataLocality from './UpdateBulkDataLocality'
 import Salvage from './Salvage'
 import { Filter, ExpansionErrorDetail } from '../../components/index'
+import { isRestoring } from './helper'
 import VolumeBulkActions from './VolumeBulkActions'
 import {
   getAttachHostModalProps,
@@ -912,9 +913,8 @@ class Volume extends React.Component {
         })
       },
     }
-
     const bulkCloneVolumeModalProps = {
-      selectedRows,
+      selectedRows: selectedRows.filter(item => !item.standby && !isRestoring(item)), // filter out standby and restoring volumes
       visible: bulkCloneVolumeVisible,
       diskTags,
       nodeTags,