fine tune the save button layout in settings page #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
changed the title
a110605
force-pushed
the
7497_button
branch
4 times, most recently
from
3dbe8c1
to
45e73c8
Compare
Signed-off-by: andy.lee <andy.lee@suse.com>
torchiaf
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fine tune the save button layout in settings page to make it
significant visiblein any browser zoom ratio or small screen.Issue
longhorn/longhorn#7497
My previous PR sticky the save button at the buttom of page.
But it will be unvisible if user zoom into bigger browser ratio (e.g. 100%). This PR makes button all visible to any zoom ratio.
Test Result
zoom out to 67%
Zoom in to 133%
In small screen