Correct original empty string won't trigger unsaved modal #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a110605
changed the title
a110605
changed the title
Signed-off-by: andy.lee <andy.lee@suse.com>
a110605
force-pushed
the
fix_7497_empty_string
branch
from
e242fc0
to
bbe244b
Compare
|
Verified all settings change locally are good to trigger unsaved modal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix defect found by QA: longhorn/longhorn#7497 (comment)
if
targetSettingOldValueis empty string or zero, the original logic won't record the unsaved change.After fix
fixed.mp4