Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT][v1.6.3] BackingImage UI improvement (backport mulitple PRs) #746

Merged
merged 7 commits into from
Jun 11, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 11, 2024

What this PR does / why we need it

PRs for [IMPROVEMENT] BackingImage UI improvement are implemented in

Cherry pick the commits to v1.6.x branch.

Issue

[BACKPORT][v1.6.3][IMPROVEMENT] BackingImage UI improvement

Test Result

Test locally

  • Acking Image should show the source of it.
    • For export-from-volume: volume-name ✅
    • For download: url ✅
    • For upload: `` (empty) ✅
  • Add filter so user can filter the BackingImage with other properties (e.g. Created From) ✅
  •  Bulk download BackingImages ✅
  •  BackingImages can show different colors for backing image status ✅
  •  Remove cleanup operation, instead, move the cleanup function in detail page  ✅
  •  Filter out non-ready status backing image in volume create modal dropdown. ✅
  • Change clean up modal wording and style ✅

Additional documentation or context

N/A

Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 requested a review from torchiaf June 11, 2024 06:39
@a110605 a110605 self-assigned this Jun 11, 2024
@a110605 a110605 requested a review from a team as a code owner June 11, 2024 06:39
@a110605 a110605 changed the title [Backport][v1.6.3] BackingImage UI improvement (backport mulitple PRs) [BACKPORT][v1.6.3] BackingImage UI improvement (backport mulitple PRs) Jun 11, 2024
Copy link

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit d498597 into longhorn:v1.6.x Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants