Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backing image encryption and clone support on UI #762

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 26, 2024

What this PR does / why we need it

  • allow user to clone backing image with encrypt / decrypt / ignore options
  • show a "lock" icon besides encrypted backing image.
  • refactor
    • fix icon beside backing image name
    • put nodeStatusColorMap and diskStatusColorMap in utils/status.js

Issue

[UI][FEATURE] Add backing image encryption and clone support

Test Result

Encrypt backing image

Screenshot 2024-07-08 at 11 10 32 AM

Decrypt backing image
Screenshot 2024-07-08 at 11 10 50 AM

Simple clone (choose ignore) backing image

Screenshot 2024-07-08 at 11 10 40 AM

Simply clone encrpyted backing image
Screenshot 2024-07-08 at 11 26 08 AM

Additional documentation or context

Note 1. This PR needs wait for longhorn-manager and backing image manager PRs merge first.
- longhorn/longhorn-manager#2876
- longhorn/backing-image-manager#251

Note. longhorn-manager need below supports, I will implement this feature in next PR.

  • copy encrypted backing image should have copied secret and secretNamespace
  • restore bbi should allow bring payload
POST http://localhost:8080/v1/backupbackingimages/parrot?action=backupBackingImageRestore
payload
{
 secret: xxx,
 secret-namespace: ooo 
}

@a110605 a110605 requested review from ChanYiLin, torchiaf and a team June 26, 2024 08:13
@a110605 a110605 changed the title Issue 8789 Add backing image encryption and clone support on UI Jun 26, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
…g image modal

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 force-pushed the issue-8789 branch 2 times, most recently from 091293c to ea6b225 Compare July 7, 2024 14:24
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 marked this pull request as ready for review July 8, 2024 03:14
@a110605 a110605 requested a review from derekbit July 8, 2024 03:14
@longhorn longhorn deleted a comment from mergify bot Jul 8, 2024
@longhorn longhorn deleted a comment from mergify bot Jul 8, 2024
@derekbit
Copy link
Member

derekbit commented Jul 8, 2024

cc @ChanYiLin

Copy link

@ChanYiLin ChanYiLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 546becd into longhorn:master Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants