show error message and disable buttons if backup target is not available #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andy.lee <andy.lee@suse.com>
|
cc @ChanYiLin |
ChanYiLin
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Since bbi table is added in backing image page in previous PR.
We should show
backup target URL is emptyerror message in backup, backingImage or systemBackups pages and disable related buttons.Issue
longhorn/longhorn#7541
Test Result
Empty backuptarget
show_error_if_backuptarget_missing.mov
Availalbe backuptarget
backuptarget_enabled.mov
Additional documentation or context
If user input non-available backuptarget, couldn't connect it or typo.
The error msg too long to read. Maybe we can simple it to one sentence like
backup target is not availablecc @ChanYiLin