Update backup wording and restore backing image modal #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andy.lee <andy.lee@suse.com>
a110605
changed the title
a110605
changed the title
jillian-maroket
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Thanks for implementing the changes I requested in the doc PR. I'll approve this now, but I want to mention that wording issues must be fixed in success messages.
Example:
message.success(Successfully back up ${payload.name} backing image`
We should use the past tense when confirming that an action was completed. In this case, the verb should be "backed up".
Signed-off-by: andy.lee <andy.lee@suse.com>
Thanks for advice. |
|
@mergify backport v1.7.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
From doc review feedback, update the wordings.
See longhorn/website#943 (comment)
Issue
longhorn/longhorn#7541
Test Result
In volume detail page.
Additional documentation or context
This PR should backport to v1.7.x