Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align the disk/node conditions in a vertical way #806

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: align the disk/node conditions in a vertical way #806

merged 1 commit into from
Oct 15, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Oct 15, 2024 •
edited
Loading

What this PR does / why we need it

fix: align the disk/node conditions in a vertical way.

Issue

longhorn/longhorn#9629

Test Result

Add mock data in disk.conditions and node.conditions

image

@a110605 a110605 self-assigned this Oct 15, 2024
@derekbit
Copy link
Member

Can we show the conditions line by line?

Conditions
v MountPropagation
v Ready
...

@a110605
Copy link
Contributor Author

a110605 commented Oct 15, 2024 •
edited
Loading

Can we show the conditions line by line?

Conditions
v MountPropagation
v Ready
...

Will looks like below screenshot, I am fine either way.

image

@derekbit
Copy link
Member

Yes, looks not messy.

@a110605
fix: align the disk/node conditions in a vertical way within edit dis…
f8269de 
…k modal

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title fix: add flex-wrap css in edit disk modal fix: align the disk/node conditions in a vertical way Oct 15, 2024
derekbit
derekbit approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekbit
derekbit approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 05d8d91 into longhorn:master Oct 15, 2024
5 checks passed
@derekbit
Copy link
Member

@mergify backport v1.7.x

@mergify Mergify
Copy link

mergify bot commented Oct 15, 2024 •
edited
Loading

backport v1.7.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Oct 15, 2024
Merged
@derekbit derekbit mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@yangchiu yangchiu Awaiting requested review from yangchiu

@mantissahz mantissahz Awaiting requested review from mantissahz

Assignees

@a110605 a110605

Labels
bug require backport v1.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a110605 @derekbit