Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Check kernel module dm_crypt on host machines #9153

Open
1 of 3 tasks
derekbit opened this issue Aug 1, 2024 · 3 comments
Open
1 of 3 tasks

[IMPROVEMENT] Check kernel module dm_crypt on host machines #9153

derekbit opened this issue Aug 1, 2024 · 3 comments
Assignees
Labels
area/cli area/external-dependency External dependency related like packages on host, distro version, etc backport/1.7.2 component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Milestone

Comments

@derekbit
Copy link
Member

derekbit commented Aug 1, 2024

Is your improvement request related to a feature? Please describe (👍 if you like this request)

  1. Add the necessary dm_crypt kernel module for encrypted volumes in the official document
  2. Add the necessary dm_crypt kernel module check in the node.status.conditions
  3. Add the necessary dm_crypt kernel module check in the longhornctl

Describe the solution you'd like

Describe alternatives you've considered

Additional context

#9135

Tasks

  • doc: The documentation for the necessary dm_crypt kernel module for encrypted volumes
  • longhorn-manager: dm_crypt kernel module check in the node.status.conditions
  • cli: dm_crypt kernel module check
@derekbit derekbit added component/longhorn-manager Longhorn manager (control plane) priority/0 Must be implement or fixed in this release (managed by PO) require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated kind/improvement Request for improvement of existing function require/backport Require backport. Only used when the specific versions to backport have not been definied. area/cli labels Aug 1, 2024
@derekbit derekbit added this to the v1.8.0 milestone Aug 1, 2024
@derekbit derekbit added the area/external-dependency External dependency related like packages on host, distro version, etc label Aug 1, 2024
@longhorn-io-github-bot
Copy link

longhorn-io-github-bot commented Aug 13, 2024

Pre Ready-For-Testing Checklist

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  • CLI:
  1. The command longhornctl check preflight can check if the module dm_crypt is loaded or not
  2. The command longhornctl install preflight can load the module dm_crypt
  • Longhorn node:
  1. The node.Status.Condition ModulesLoaded will show whether the module dm_crypt is loaded or not.

@innobead
Copy link
Member

Let's backport this.

@derekbit
Copy link
Member Author

We need to figure out how to check the built-in kernel module. Let's move it to v1.7.2 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/external-dependency External dependency related like packages on host, distro version, etc backport/1.7.2 component/longhorn-manager Longhorn manager (control plane) kind/improvement Request for improvement of existing function priority/0 Must be implement or fixed in this release (managed by PO) require/backport Require backport. Only used when the specific versions to backport have not been definied. require/doc Require updating the longhorn.io documentation require/manual-test-plan Require adding/updating manual test cases if they can't be automated
Projects
Status: Ready For Testing
Development

No branches or pull requests

5 participants