Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check kernel module dm_crypt on host machines #66

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

mantissahz
Copy link
Contributor

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#9153

What this PR does / why we need it:

  • check if the module dm_crypt is enabled
  • enable the module dm_crypt

Special notes for your reviewer:

Additional documentation or context

@mantissahz mantissahz self-assigned this Aug 12, 2024
@mantissahz mantissahz requested review from c3y1huang, derekbit and a team August 12, 2024 09:41
derekbit
derekbit previously approved these changes Aug 12, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

@mantissahz after resolving the commit-lint error, we can merge it.

@mantissahz mantissahz changed the title Check kernel module dm_crypt on host machines fix: check kernel module dm_crypt on host machines Aug 12, 2024
Copy link

mergify bot commented Aug 20, 2024

This pull request is now in conflict. Could you fix it @mantissahz? 🙏

@derekbit
Copy link
Member

@mantissahz Could you resolve the conflicts?

ref: longhorn/longhorn 9153

Signed-off-by: James Lu <james.lu@suse.com>
ref: longhorn/longhorn 9153

Signed-off-by: James Lu <james.lu@suse.com>
@derekbit derekbit merged commit 954125d into longhorn:master Aug 20, 2024
6 checks passed
@mantissahz
Copy link
Contributor Author

@Mergifyio backport v1.7.x

Copy link

mergify bot commented Sep 27, 2024

backport v1.7.x

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants