Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-balance): disk in pressure #15

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang commented Jun 17, 2024

Which issue(s) this PR fixes:

Issue longhorn/longhorn#4105

What this PR does / why we need it:

Introduce new fields to FilesSyncRequest and EngineReplicaAddRequest to handle local file copying when replicas are on the same node.

Special notes for your reviewer:

None

Additional documentation or context

None

@c3y1huang c3y1huang self-assigned this Jun 17, 2024
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from b0fcfba to 5ce8e91 Compare June 17, 2024 07:26
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch 3 times, most recently from 45cbe4b to 03295a9 Compare June 25, 2024 02:00
@c3y1huang c3y1huang marked this pull request as ready for review June 25, 2024 02:02
longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
…uest

longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-4105

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-auto-balance-node-disks branch from 03295a9 to 3f48d76 Compare July 1, 2024 06:50
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

derekbit commented Jul 2, 2024

@c3y1huang Is it ready?

@c3y1huang
Copy link
Contributor Author

@c3y1huang Is it ready?

Ready for review.

@c3y1huang c3y1huang requested a review from derekbit July 2, 2024 04:57
@derekbit derekbit merged commit 949485b into longhorn:main Jul 2, 2024
2 checks passed
@c3y1huang c3y1huang deleted the feat-auto-balance-node-disks branch July 3, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants