-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auto-balance): disk in pressure #15
Merged
derekbit
merged 3 commits into
longhorn:main
from
c3y1huang:feat-auto-balance-node-disks
Jul 2, 2024
Merged
feat(auto-balance): disk in pressure #15
derekbit
merged 3 commits into
longhorn:main
from
c3y1huang:feat-auto-balance-node-disks
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
June 17, 2024 07:26
b0fcfba
to
5ce8e91
Compare
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
3 times, most recently
from
June 25, 2024 02:00
45cbe4b
to
03295a9
Compare
derekbit
reviewed
Jun 30, 2024
derekbit
reviewed
Jun 30, 2024
derekbit
reviewed
Jun 30, 2024
derekbit
reviewed
Jun 30, 2024
longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
…uest longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-4105 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-auto-balance-node-disks
branch
from
July 1, 2024 06:50
03295a9
to
3f48d76
Compare
derekbit
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@c3y1huang Is it ready? |
Ready for review. |
derekbit
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#4105
What this PR does / why we need it:
Introduce new fields to
FilesSyncRequest
andEngineReplicaAddRequest
to handle local file copying when replicas are on the same node.Special notes for your reviewer:
None
Additional documentation or context
None