Skip to content

revert: remove EngineBackupRestoreFinish #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 33 additions & 31 deletions generated-py/imrpc/proxy_pb2.py

Large diffs are not rendered by default.

34 changes: 34 additions & 0 deletions generated-py/imrpc/proxy_pb2_grpc.py
Original file line number Diff line number Diff line change
@@ -125,6 +125,11 @@ def __init__(self, channel):
request_serializer=imrpc_dot_proxy__pb2.ProxyEngineRequest.SerializeToString,
response_deserializer=imrpc_dot_proxy__pb2.EngineBackupRestoreStatusProxyResponse.FromString,
)
self.BackupRestoreFinish = channel.unary_unary(
'/imrpc.ProxyEngineService/BackupRestoreFinish',
request_serializer=imrpc_dot_proxy__pb2.EngineBackupRestoreFinishRequest.SerializeToString,
response_deserializer=google_dot_protobuf_dot_empty__pb2.Empty.FromString,
)
self.CleanupBackupMountPoints = channel.unary_unary(
'/imrpc.ProxyEngineService/CleanupBackupMountPoints',
request_serializer=google_dot_protobuf_dot_empty__pb2.Empty.SerializeToString,
@@ -307,6 +312,13 @@ def BackupRestoreStatus(self, request, context):
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def BackupRestoreFinish(self, request, context):
"""Deprecated: retained for compatibility with v1.7.x and earlier versions.
"""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def CleanupBackupMountPoints(self, request, context):
"""Missing associated documentation comment in .proto file."""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
@@ -474,6 +486,11 @@ def add_ProxyEngineServiceServicer_to_server(servicer, server):
request_deserializer=imrpc_dot_proxy__pb2.ProxyEngineRequest.FromString,
response_serializer=imrpc_dot_proxy__pb2.EngineBackupRestoreStatusProxyResponse.SerializeToString,
),
'BackupRestoreFinish': grpc.unary_unary_rpc_method_handler(
servicer.BackupRestoreFinish,
request_deserializer=imrpc_dot_proxy__pb2.EngineBackupRestoreFinishRequest.FromString,
response_serializer=google_dot_protobuf_dot_empty__pb2.Empty.SerializeToString,
),
'CleanupBackupMountPoints': grpc.unary_unary_rpc_method_handler(
servicer.CleanupBackupMountPoints,
request_deserializer=google_dot_protobuf_dot_empty__pb2.Empty.FromString,
@@ -903,6 +920,23 @@ def BackupRestoreStatus(request,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def BackupRestoreFinish(request,
target,
options=(),
channel_credentials=None,
call_credentials=None,
insecure=False,
compression=None,
wait_for_ready=None,
timeout=None,
metadata=None):
return grpc.experimental.unary_unary(request, target, '/imrpc.ProxyEngineService/BackupRestoreFinish',
imrpc_dot_proxy__pb2.EngineBackupRestoreFinishRequest.SerializeToString,
google_dot_protobuf_dot_empty__pb2.Empty.FromString,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def CleanupBackupMountPoints(request,
target,
68 changes: 35 additions & 33 deletions generated-py/spdkrpc/spdk_pb2.py

Large diffs are not rendered by default.

33 changes: 33 additions & 0 deletions generated-py/spdkrpc/spdk_pb2_grpc.py
Original file line number Diff line number Diff line change
@@ -235,6 +235,11 @@ def __init__(self, channel):
request_serializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreRequest.SerializeToString,
response_deserializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreResponse.FromString,
)
self.EngineBackupRestoreFinish = channel.unary_unary(
'/spdkrpc.SPDKService/EngineBackupRestoreFinish',
request_serializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreFinishRequest.SerializeToString,
response_deserializer=google_dot_protobuf_dot_empty__pb2.Empty.FromString,
)
self.EngineRestoreStatus = channel.unary_unary(
'/spdkrpc.SPDKService/EngineRestoreStatus',
request_serializer=spdkrpc_dot_spdk__pb2.RestoreStatusRequest.SerializeToString,
@@ -549,6 +554,12 @@ def EngineBackupRestore(self, request, context):
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def EngineBackupRestoreFinish(self, request, context):
"""Missing associated documentation comment in .proto file."""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')

def EngineRestoreStatus(self, request, context):
"""Missing associated documentation comment in .proto file."""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
@@ -826,6 +837,11 @@ def add_SPDKServiceServicer_to_server(servicer, server):
request_deserializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreRequest.FromString,
response_serializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreResponse.SerializeToString,
),
'EngineBackupRestoreFinish': grpc.unary_unary_rpc_method_handler(
servicer.EngineBackupRestoreFinish,
request_deserializer=spdkrpc_dot_spdk__pb2.EngineBackupRestoreFinishRequest.FromString,
response_serializer=google_dot_protobuf_dot_empty__pb2.Empty.SerializeToString,
),
'EngineRestoreStatus': grpc.unary_unary_rpc_method_handler(
servicer.EngineRestoreStatus,
request_deserializer=spdkrpc_dot_spdk__pb2.RestoreStatusRequest.FromString,
@@ -1629,6 +1645,23 @@ def EngineBackupRestore(request,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def EngineBackupRestoreFinish(request,
target,
options=(),
channel_credentials=None,
call_credentials=None,
insecure=False,
compression=None,
wait_for_ready=None,
timeout=None,
metadata=None):
return grpc.experimental.unary_unary(request, target, '/spdkrpc.SPDKService/EngineBackupRestoreFinish',
spdkrpc_dot_spdk__pb2.EngineBackupRestoreFinishRequest.SerializeToString,
google_dot_protobuf_dot_empty__pb2.Empty.FromString,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)

@staticmethod
def EngineRestoreStatus(request,
target,
1,045 changes: 561 additions & 484 deletions pkg/generated/imrpc/proxy.pb.go

Large diffs are not rendered by default.

37 changes: 37 additions & 0 deletions pkg/generated/imrpc/proxy_grpc.pb.go
1,175 changes: 624 additions & 551 deletions pkg/generated/spdkrpc/spdk.pb.go

Large diffs are not rendered by default.

37 changes: 37 additions & 0 deletions pkg/generated/spdkrpc/spdk_grpc.pb.go
6 changes: 6 additions & 0 deletions protobuf/imrpc/proxy.proto
Original file line number Diff line number Diff line change
@@ -35,6 +35,7 @@ service ProxyEngineService {
rpc SnapshotBackupStatus(EngineSnapshotBackupStatusRequest) returns (EngineSnapshotBackupStatusProxyResponse);
rpc BackupRestore(EngineBackupRestoreRequest) returns (EngineBackupRestoreProxyResponse);
rpc BackupRestoreStatus(ProxyEngineRequest) returns (EngineBackupRestoreStatusProxyResponse);
rpc BackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty); // Deprecated: retained for compatibility with v1.7.x and earlier versions.
rpc CleanupBackupMountPoints(google.protobuf.Empty) returns (google.protobuf.Empty);

rpc ReplicaAdd(EngineReplicaAddRequest) returns (google.protobuf.Empty);
@@ -229,6 +230,11 @@ message EngineBackupRestoreStatus {
string backup_url = 8;
}

// Deprecated: retained for compatibility with v1.7.x and earlier versions.
message EngineBackupRestoreFinishRequest {
ProxyEngineRequest proxy_engine_request = 1;
}

message EngineReplicaAddRequest {
ProxyEngineRequest proxy_engine_request = 1;

6 changes: 6 additions & 0 deletions protobuf/spdkrpc/spdk.proto
Original file line number Diff line number Diff line change
@@ -52,6 +52,7 @@ service SPDKService {
rpc EngineBackupCreate(BackupCreateRequest) returns (BackupCreateResponse) {}
rpc EngineBackupStatus(BackupStatusRequest) returns (BackupStatusResponse) {}
rpc EngineBackupRestore(EngineBackupRestoreRequest) returns (EngineBackupRestoreResponse) {}
rpc EngineBackupRestoreFinish(EngineBackupRestoreFinishRequest) returns (google.protobuf.Empty) {} // Deprecated: retained for compatibility with v1.7.x and earlier versions.
rpc EngineRestoreStatus(RestoreStatusRequest) returns (RestoreStatusResponse) {}

rpc DiskCreate(DiskCreateRequest) returns (Disk);
@@ -386,6 +387,11 @@ message EngineBackupRestoreResponse {
map<string, string> errors = 4;
}

// Deprecated: retained for compatibility with v1.7.x and earlier versions.
message EngineBackupRestoreFinishRequest {
string engine_name = 1;
}

message ReplicaBackupRestoreRequest {
string backup_url = 1;
string replica_name = 2;