Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2 data engine): add V2 Data Engine CPU Mask #1002

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8835

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Oct 15, 2024
@derekbit derekbit requested a review from a team as a code owner October 15, 2024 03:20
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 1081d3c
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/670e8eb286a281000865775c
😎 Deploy Preview https://deploy-preview-1002--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny suggestions for you to consider. Thanks.

content/docs/1.8.0/references/settings.md Outdated Show resolved Hide resolved
content/docs/1.8.0/references/settings.md Outdated Show resolved Hide resolved
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment.

Longhorn 8835

Signed-off-by: Derek Su <derek.su@suse.com>
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@derekbit derekbit merged commit ac60fc6 into longhorn:master Oct 16, 2024
6 checks passed
@derekbit derekbit deleted the issue-8835 branch October 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants