doc: engine version enforcement #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
3 times, most recently
from
f3de2e6
to
d4c253e
Compare
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
from
d4c253e
to
a2c7ede
Compare
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
3 times, most recently
from
2a9bea6
to
44cbdb8
Compare
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
from
44cbdb8
to
1a4050f
Compare
innobead
requested changes
Dec 26, 2023
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
2 times, most recently
from
888d62a
to
97d0561
Compare
There was a problem hiding this comment.
@c3y1huang I moved the text that you added to make the meaning clearer.
|
|
||
| When upgrading through Helm, a component compatibility check is automatically performed. If the new Longhorn is not compatible with the engine images that are currently in use, the upgrade path is blocked through a pre-hook mechanism. | ||
|
|
||
| If you installed Longhorn using the manifests, engine upgrades are enforced by the Longhorn Manager. Attempts to upgrade Longhorn Manager may cause unsuccessful pod launches and generate corresponding error logs, although it poses no harm. If you encounter such errors, you must revert to the previous Longhorn version and then upgrade the engines that are using the incompatible engine images before the next upgrade. |
There was a problem hiding this comment.
Suggested change
| If you installed Longhorn using the manifests, engine upgrades are enforced by the Longhorn Manager. Attempts to upgrade Longhorn Manager may cause unsuccessful pod launches and generate corresponding error logs, although it poses no harm. If you encounter such errors, you must revert to the previous Longhorn version and then upgrade the engines that are using the incompatible engine images before the next upgrade. | |
| If you installed Longhorn using a manifest file, engine upgrades are enforced by Longhorn Manager. Attempts to upgrade Longhorn Manager may cause unsuccessful pod launches (that pose no harm to the system) and generate corresponding error logs. If you encounter such errors, you must revert to the previous Longhorn Manager version and then upgrade engines with incompatible engine images. |
There was a problem hiding this comment.
I've updated the top section of the suggestion. However, the lower part looks a bit odd to me.
you must revert to the previous Longhorn Manager version
The user should revert the Longhorn version, not just the manager's version.
upgrade engines with incompatible engine images
This sounds like we are asking the user to upgrade the engine using an incompatible engine image.
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
from
97d0561
to
0c40298
Compare
There was a problem hiding this comment.
@c3y1huang Apologies, I was working off of an older version of the text. Let's revert to what we had before the latest addition.
ref: longhorn-5842 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-engine-version-enforcement
branch
from
0c40298
to
12099a6
Compare
innobead
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#5842