Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(1.6.0): Talos Linux support #827

Merged
merged 2 commits into from
Jan 3, 2024
Merged

doc(1.6.0): Talos Linux support #827

merged 2 commits into from
Jan 3, 2024

Conversation

c3y1huang
Copy link
Contributor

@c3y1huang c3y1huang self-assigned this Dec 29, 2023
@c3y1huang c3y1huang force-pushed the feat-talos branch 3 times, most recently from f92fe86 to 7bb10c1 Compare December 29, 2023 04:37
@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 1e2013f
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/6594dc31f8bf06000875b6f3
😎 Deploy Preview https://deploy-preview-827--longhornio.netlify.app/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c3y1huang c3y1huang marked this pull request as ready for review December 29, 2023 04:42
@c3y1huang c3y1huang requested a review from a team as a code owner December 29, 2023 04:42
@c3y1huang c3y1huang mentioned this pull request Dec 29, 2023
Closed
jillian-maroket
jillian-maroket reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
jillian-maroket
jillian-maroket reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the link text per feedback.

content/docs/1.6.0/deploy/install/_index.md Outdated Show resolved Hide resolved
@c3y1huang
Copy link
Contributor Author

c3y1huang commented Jan 2, 2024 •
edited
Loading

TODO: missing Pod Security enforcement document.

innobead
innobead requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to mentione Talos only supporting v1 data volume. (or can we support v2?) If yes, it's better to have an example about bind mount the device on host.

content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Show resolved Hide resolved
content/docs/1.6.0/advanced-resources/os-distro-specific/talos-linux-support.md Outdated Show resolved Hide resolved
@c3y1huang
doc(1.6.0): improve OS specific installation readabiltiy
80abb6a 
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-talos branch 4 times, most recently from 885bf09 to 894c441 Compare January 3, 2024 03:57
@c3y1huang
doc(1.6.0): Talos Linux support
1e2013f 
longhorn-3161

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@innobead innobead merged commit 327d2e5 into longhorn:master Jan 3, 2024
6 checks passed
@c3y1huang c3y1huang deleted the feat-talos branch January 3, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@jillian-maroket jillian-maroket Awaiting requested review from jillian-maroket

Assignees

@c3y1huang c3y1huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c3y1huang @innobead @jillian-maroket