doc: add descriptions for helm values. #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for longhornio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@mantissahz I updated the descriptions I drafted to address David's feedback.
@jillian-maroket, |
innobead
previously approved these changes
Jan 3, 2024
There was a problem hiding this comment.
LGTM. Waiting for @jillian-maroket approval first before merging this.
There was a problem hiding this comment.
@mantissahz Let me know if you have concerns about the changes.
Add descriptions for the values `helmPreUpgradeCheckerJob` and `serviceMonitor`. Ref: 7485 Signed-off-by: James Lu <james.lu@suse.com>
innobead
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add descriptions for the values
helmPreUpgradeCheckerJobandserviceMonitor.Ref: longhorn/longhorn#7485