Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add last replica timeout behavior to important notes #980

Merged
merged 1 commit into from
Sep 3, 2024
Merged

docs: add last replica timeout behavior to important notes #980

merged 1 commit into from
Sep 3, 2024

Conversation

ejweber
Copy link
Collaborator

@ejweber ejweber commented Aug 30, 2024

@ejweber ejweber requested a review from a team as a code owner August 30, 2024 15:33
@ejweber ejweber mentioned this pull request Aug 30, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 3bd6e16
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d72f816fc7110008422e1f
😎 Deploy Preview https://deploy-preview-980--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@derekbit
Copy link
Member

cc @jillian-maroket

@derekbit derekbit mentioned this pull request Aug 31, 2024
Merged
innobead
innobead previously approved these changes Aug 31, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM. But wiring for reviews by doc engineer.

P.S. @derekbit we probably should start thinking of how different behaviors are managed in v1 mad v2 in the future.

jillian-maroket
jillian-maroket reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

content/docs/1.7.1/important-notes/_index.md Outdated Show resolved Hide resolved
content/docs/1.7.1/references/settings.md Outdated Show resolved Hide resolved
@ejweber
docs: add last replica timeout behavior to important notes
3bd6e16 
Longhorn 8711

Signed-off-by: Eric Weber <eric.weber@suse.com>
@ejweber ejweber force-pushed the 8711-last-replica-timeout-important-notes branch from 09f02b5 to 3bd6e16 Compare September 3, 2024 15:47
@derekbit derekbit merged commit 15f8f3d into longhorn:master Sep 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillian-maroket jillian-maroket jillian-maroket left review comments

@derekbit derekbit derekbit approved these changes

@innobead innobead innobead left review comments

@jhkrug jhkrug Awaiting requested review from jhkrug

Assignees

@ejweber ejweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ejweber @derekbit @innobead @jillian-maroket