Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2 volume): fix Node Disk Support #983

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

derekbit
Copy link
Member

@derekbit derekbit commented Sep 4, 2024

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Sep 4, 2024
@derekbit derekbit requested a review from a team as a code owner September 4, 2024 11:45
Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 0defd74
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66d8586e2c493400080f5606
😎 Deploy Preview https://deploy-preview-983--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for 1.8.0, if agreed, they should be applied to the other versions.

Signed-off-by: Derek Su <derek.su@suse.com>
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the diskDrive fields.
The content looks good to me.

@derekbit derekbit merged commit b84ae07 into longhorn:master Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants