Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(1.8.0): add replica auto-balance to best-practice #993

Merged

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue None

What this PR does / why we need it:

Recommend setting the replica auto-balance setting option to least-effort as best practice for the production environment.

Special notes for your reviewer:

Additional documentation or context

https://suse.slack.com/archives/C02CLV7D2KH/p1726814707259759

@c3y1huang c3y1huang self-assigned this Sep 20, 2024
@c3y1huang c3y1huang force-pushed the doc-best-practice-replica-auto-balance branch from 279e099 to ffb2ff6 Compare September 20, 2024 09:02
@c3y1huang c3y1huang marked this pull request as ready for review September 20, 2024 09:03
@c3y1huang c3y1huang requested a review from a team as a code owner September 20, 2024 09:03
Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 279e099
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66ed3a09cfcdb000081eb4c7
😎 Deploy Preview https://deploy-preview-993--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 8650b11
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/66f375d084b2c60008a21189
😎 Deploy Preview https://deploy-preview-993--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c3y1huang c3y1huang force-pushed the doc-best-practice-replica-auto-balance branch from ffb2ff6 to 1f14bc4 Compare September 20, 2024 09:11
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion

content/docs/1.8.0/best-practices.md Outdated Show resolved Hide resolved
@c3y1huang c3y1huang force-pushed the doc-best-practice-replica-auto-balance branch 2 times, most recently from 04c05d7 to 5ead78c Compare September 24, 2024 01:21
jhkrug
jhkrug previously approved these changes Sep 24, 2024
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm

innobead
innobead previously approved these changes Sep 25, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@innobead
Copy link
Member

innobead commented Sep 25, 2024

We can also add this to 1.7 and 1.6 if the feature is available in those versions.

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang dismissed stale reviews from innobead and jhkrug via 8650b11 September 25, 2024 02:30
@c3y1huang c3y1huang force-pushed the doc-best-practice-replica-auto-balance branch from 5ead78c to 8650b11 Compare September 25, 2024 02:30
@innobead innobead merged commit f8be0de into longhorn:master Sep 25, 2024
6 checks passed
@c3y1huang c3y1huang deleted the doc-best-practice-replica-auto-balance branch September 25, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants