Remove the bought shields penalty after conquest #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conquest removes all shields from the city production. This means the penalty on bought shields is no longer needed. Not resetting to zero resulted in negative shields with the following sequence of events: 1. Player A buys something 2. Player B conquers the city (the shield stock becomes 0) 3. Player B changes production 4. The bought shields penalty is deduced from the shield stock This is needed in a few more cases such as sabotage. Implement the change in nullify_prechange_production that is already used when changing production. Noticed by TriClad in Sim06.
lmoureaux
added
bug
jwrober
approved these changes
Feb 3, 2025
|
back port approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conquest removes all shields from the city production. This means the penalty on bought shields is no longer needed.
Not resetting to zero resulted in negative shields with the following sequence of events:
This is needed in a few more cases such as sabotage. Implement the change in nullify_prechange_production that is already used when changing production.
Noticed by TriClad in Sim06.
Backport recommended.