optimize decode logical and fix some bugs

cluster/cluster.go

@@ -187,11 +187,7 @@ func (c *cluster) delMember(addr string) {
 		}
 	}
 	if index != -1 {
-		if index == len(c.members)-1 {
-			c.members = c.members[:index]
-		} else {
-			c.members = append(c.members[:index], c.members[index+1:]...)
-		}
+		c.members = append(c.members[:index], c.members[index+1:]...)
 	}
 	c.mu.Unlock()
 }

cluster/handler.go

@@ -140,11 +140,7 @@ func (h *LocalHandler) delMember(addr string) {
 	for name, members := range h.remoteServices {
 		for i, maddr := range members {
 			if addr == maddr.ServiceAddr {
-				if i == len(members)-1 {
-					members = members[:i]
-				} else {
-					members = append(members[:i], members[i+1:]...)
-				}
+				members = append(members[:i], members[i+1:]...)
 			}
 		}
 		if len(members) == 0 {
@@ -232,16 +228,20 @@ func (h *LocalHandler) handle(conn net.Conn) {
 		packets, err := agent.decoder.Decode(buf[:n])
 		if err != nil {
 			log.Println(err.Error())
-			return
-		}
 
-		if len(packets) < 1 {
-			continue
+			// process packets decoded
+			for _, p := range packets {
+				if err := h.processPacket(agent, p); err != nil {
+					log.Println(err.Error())
+					return
+				}
+			}
+			return
 		}
 
-		// process all packet
-		for i := range packets {
-			if err := h.processPacket(agent, packets[i]); err != nil {
+		// process all packets
+		for _, p := range packets {
+			if err := h.processPacket(agent, p); err != nil {
 				log.Println(err.Error())
 				return
 			}

component/service.go

@@ -26,13 +26,12 @@ import (
 )
 
 type (
-	//Handler represents a message.Message's handler's meta information.
 	//Handler represents a message.Message's handler's meta information.
 	Handler struct {
 		Receiver reflect.Value  // receiver of method
 		Method   reflect.Method // method stub
-		Type     reflect.Type   // low-level type of method
-		IsRawArg bool           // whether the data need to serialize
+		Type     reflect.Type   // arg type of method
+		IsRawArg bool           // whether the data need to unserialize
 	}
 
 	// Service implements a specific service, some of it's methods will be

examples/cluster/main.go

@@ -123,7 +123,7 @@ func runGate(args *cli.Context) error {
 	}
 
 	masterAddr := args.String("master")
-	if listen == "" {
+	if masterAddr == "" {
 		return errors.Errorf("master address cannot empty")
 	}
 

group_test.go

@@ -29,7 +29,7 @@ func TestChannel_Add(t *testing.T) {
 		t.Fatalf("count expect: %d, got: %d", paraCount, c.Count())
 	}
 
-	n := rand.Int63n(int64(paraCount) + 1)
+	n := rand.Int63n(int64(paraCount)) + 1
 	if !c.Contains(n) {
 		t.Fail()
 	}

internal/codec/codec.go

@@ -98,10 +98,8 @@ func (c *Decoder) Decode(data []byte) ([]*packet.Packet, error) {
 		}
 
 		if err = c.forward(); err != nil {
-			return nil, err
-
+			return packets, err
 		}
-
 	}
 
 	return packets, nil