Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign User Agent and x-looker-appid headers in Looker JDBC Driver #12

Merged

Conversation

Anthrino
Copy link

@Anthrino Anthrino commented Jun 6, 2024

Fixes b/343254086 (refer for additional context).

Verified this change using sqlline with the updated driver jar, request headers included assigned values.

image

Copy link

@tanclary tanclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing comments

@Anthrino Anthrino force-pushed the connector-user-agent-param branch from a7fe452 to 4ba364f Compare June 6, 2024 22:40
@Anthrino Anthrino changed the title Assigned User Agent and x-looker-appid headers in Looker JDBC Driver … Assign User Agent and x-looker-appid headers in Looker JDBC Driver and correct flaky DST timestamp tests Jun 6, 2024
@Anthrino Anthrino changed the title Assign User Agent and x-looker-appid headers in Looker JDBC Driver and correct flaky DST timestamp tests Assign User Agent and x-looker-appid headers in Looker JDBC Driver Jun 7, 2024
@Anthrino Anthrino merged commit 2e892a6 into looker-open-source:looker Jun 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants