Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable inconsistent DST/Ansi/Gregorian timestamp conversion tests #13

Merged

Conversation

Anthrino
Copy link

@Anthrino Anthrino commented Jun 7, 2024

DST = Daylight Savings Time
Ansi = Ansi SQL timestamp format
Gregorian = Gregorian calendar date shift

Fixes: b/344910002 (refer for additional context)

NOTE: The one failing one CI job can be considered inconsequential and fixed later, it is from a calcite test where the exception message thrown has a typo/repetition.

@Anthrino Anthrino force-pushed the disable-timestamp-conv-tests branch 8 times, most recently from 2afde77 to 045a7e5 Compare June 11, 2024 00:30
@Anthrino Anthrino force-pushed the disable-timestamp-conv-tests branch from 045a7e5 to 8b3ea66 Compare June 11, 2024 00:41
.github/workflows/main.yml Outdated Show resolved Hide resolved
@Anthrino Anthrino merged commit ba21960 into looker-open-source:looker Jun 11, 2024
11 of 12 checks passed
@Anthrino Anthrino deleted the disable-timestamp-conv-tests branch June 11, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants