Skip to content

Commit

Permalink
[b/328442222] Fix typo in DIV definition (#46)
Browse files Browse the repository at this point in the history
The arguments should be separated by commas, I think the backslash is probably just a typo.
  • Loading branch information
tanclary authored Mar 13, 2024
1 parent 25355ae commit 51b01ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion connector/tableau/looker-jdbc/dialect.tdd
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<function group='numeric' name='DIV' return-type='int'>
<!-- BQ's `SAFE_DIVIDE` returns NULL for division by zero. Based on the example dialect, this seems to be what Tableau expects.
It also always returns a real number, so cast to the expected integer. -->
<formula>CAST(SAFE_DIVIDE((%1) / (%2)) AS INTEGER)</formula>
<formula>CAST(SAFE_DIVIDE((%1), (%2)) AS INTEGER)</formula>
<argument type='int' />
<argument type='int' />
</function>
Expand Down

0 comments on commit 51b01ae

Please sign in to comment.