Looker Model metadata #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows dependent projects to run tests using Bazel. (Previously, DiffRepository would give errors because Bazel has packaged the .xml files it needs inside JAR files.) Close apache#2750
…pache#7) Related to CALCITE-5346. Previously we relied on the parser to map unrecognized datatypes to a known type using SqlAlienSystemTypeNameSpec. This worked but made it difficult to change or add new types as necessary. One would have to update at least 3 different parsers (babel, core, server) to make a change. This change allows for declaring user-defined types at the root of a schema model and allows for easy type alias mapping. These data types are shared by all schema in the model so cast and DDL expressions do not need to scope data type references to a particular sub-schema. For example: ``` inline: { version: '1.0', types: [ { name: 'BOOL', type: 'BOOLEAN' }, { name: 'BYTES', type: 'VARBINARY' }, ... ], ``` Allows for `CAST("true" as BOOL)`
…de node) (apache#28) * Add tests to fix later * Update test * Add in type field to RelJson.toJson and update tests * CALCITE-5607 / Serialize return type during RelJson.toJson(RexNode node) * Update test comment --------- Co-authored-by: Oliver Lee <oliverlee@google.com>
…K, WEEK(WEEKDAY) (apache#32) * [CALCITE-5449] Allow EXTRACT() to accept time frames * Fix getMonotonicity() override * Lint * Refactor DAYOFWEEK, DAYOFYEAR --------- Co-authored-by: tanclary <116591231+tanclary@users.noreply.github.com> Co-authored-by: Tanner Clary <tannerclary@google.com>
tanclary
reviewed
Aug 4, 2023
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
Outdated
Show resolved
Hide resolved
wnob
suggested changes
Aug 4, 2023
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
Outdated
Show resolved
Hide resolved
| @@ -284,6 +295,52 @@ protected static Connection getRemoteConnection() throws SQLException { | |||
| .returns(CalciteAssert.checkResultContains("COLUMN_NAME=EMPNO")); | |||
| } | |||
|
|
|||
| @Test void testRemoteColumnsMetadata() throws SQLException { | |||
| final Connection connection = | |||
There was a problem hiding this comment.
nit: arrange your tests in AAA form: http://go/unit-testing-practices#structure
| * Gets Looker Explore metadata if available. | ||
| */ | ||
| default HashMap<String, Object> getTableMetadata() { | ||
| HashMap<String, Object> map = new HashMap<>(); |
There was a problem hiding this comment.
Let's avoid hash maps in APIs whenever possible, even internal ones. This is how helltool ended up with so many functions with a single hash map argument instead of individual arguments.
The best thing for here is probably to define a new data class called ExtraTableMetadata that functions like the hash map, but with all the expected fields spelled out.
olivrlee
force-pushed
the
model_metadata_
branch
from
839917c
to
78c444d
Compare
olivrlee
force-pushed
the
model_metadata_
branch
from
78c444d
to
cbb02c6
Compare
…hen instantiating tables in the CalciteMetaImpl tables() call
olivrlee
commented
Sep 2, 2023
core/src/main/java/org/apache/calcite/jdbc/CalciteMetaImpl.java
Outdated
Show resolved
Hide resolved
olivrlee
commented
Sep 2, 2023
core/src/main/java/org/apache/calcite/jdbc/CalciteConnectionImpl.java
Outdated
Show resolved
Hide resolved
olivrlee
commented
Sep 6, 2023
|
|
||
| // Got a RedundantModifier alert, however CalciteMetaImpl does need this constructor to be | ||
| // explicitly public in order to create an instance. | ||
| // CHECKSTYLE: IGNORE 2 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.