Update connection field validation rule #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjbanghart
reviewed
Nov 8, 2023
| @@ -19,7 +19,7 @@ | |||
| <!-- Connection fields, part of the Tableau connector SDK; see manifest.xml. --> | |||
| <connection-fields> | |||
| <field name="server" label="Server" value-type="string" category="endpoint" default-value="localhost"> | |||
| <validation-rule reg-exp="^(([a-zA-Z]|[a-zA-Z][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z]|[A-Za-z][A-Za-z0-9\-]*[A-Za-z0-9])$"/> | |||
| <validation-rule reg-exp="^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])$"/> | |||
There was a problem hiding this comment.
Might as well simplify to [a-zA-Z0-9]* right?
There was a problem hiding this comment.
What about ^[a-zA-Z0-9\.\-]*$?
There was a problem hiding this comment.
That should do it too, lets do some manual testing on https://regex101.com/
There was a problem hiding this comment.
My very scientific tests seem to be passing
tanclary
force-pushed
the
update-validation-regex
branch
from
dd99bfe
to
02bed33
Compare
tjbanghart
merged commit dee1399
into
looker-open-source:connector
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.