[b/330573524] Prevent IF from treating NULL as FALSE #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tableau offers the IIF function with the signature IIF(bool, val1, val2[, val3]). If bool is TRUE, it returns val1, if it is FALSE, it returns val2, and if it is NULL, it returns val3 if provided, otherwise it returns NULL. Previously, we translated this behavior by rewriting it as BigQuery's IF. The issue however, is that if bool is NULL, BigQuery defaults to val2 instead of NULL or val3. This commit corrects for that by wrapping the expression in another IF that checks if bool is NULL. If it is, it returns val3 if specified, otherwise NULL. If bool is not null, it follows normal IF behavior.
olivrlee
reviewed
Mar 27, 2024
olivrlee
approved these changes
Mar 27, 2024
tanclary
merged commit 8dc113a
into
looker-open-source:connector
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tableau offers the
IIFfunction with the signatureIIF(bool, val1, val2[, val3]). IfboolisTRUE, it returnsval1, if it isFALSE, it returnsval2, and if it isNULL, it returnsval3if provided, otherwise it returnsNULL.Previously, we translated this behavior by rewriting it as BigQuery's
IF. The issue however, is that ifboolisNULL, BigQuery defaults toval2instead ofNULLorval3.This commit corrects for that by wrapping the expression in another
IFthat checks ifboolisNULL. If it is, it returnsval3if specified, otherwiseNULL. Ifboolis not null, it follows normalIFbehavior.