Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set User Agent request param value in Tableau connector conn url string #53

Merged

Conversation

Anthrino
Copy link

@Anthrino Anthrino commented Jun 7, 2024

Fixes b/343254086 (refer for additional context and steps used below to look for api headers)

Verified by testing the updated connector taco from a local tableau instance with the experiment-tableau-bugbash auxilia looker instance, nginx ingress logs shows the user agent populated correctly.

image

@olivrlee olivrlee self-requested a review June 11, 2024 21:24
Copy link

@olivrlee olivrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!
Before you close this out, could you please document the steps you took to debug/verify this? In case months down the line we need to do this again
Maybe link the tableau setup docs, where to find the logs for the instance.

@Anthrino Anthrino merged commit 1ade6fd into looker-open-source:connector Jun 11, 2024
14 of 16 checks passed
@Anthrino Anthrino deleted the connector-user-agent-param branch June 11, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants