Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchensink code splitting improvements and upgrade to Looker components #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bryans99
Copy link
Contributor

@bryans99 bryans99 commented Apr 2, 2021

Looker components now at 1.1.3.
Kitchensink broken into its own code chunk. Initial bundle size now 300KB. Vendor bundle still large. Future PR will split vendor bundle.

Looker components now at 1.1.3.
Kitchensink broken into its own code chunk. Initial bundle size now 300KB. Vendor bundle still large. Future PR will split vendor bundle.
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -52,7 +52,7 @@ module.exports = {
},
output: {
path: __dirname + '/dist',
filename: 'bundle.js',
filename: '[name].bundle.js',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants