Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated Explore.tsx and ReadMe #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abhilash42069
Copy link
Contributor

Updated the css for Explore.tsx using <style> tag as well as added the link to the Looker/Components documentation.

@Abhilash42069
Copy link
Contributor Author

I couldn't see any option for reopening the pull request so I just created a new one. Hope this suffices. Thanks for your consideration!

@kaue
Copy link
Collaborator

kaue commented Mar 13, 2024

Thanks @Abhilash42069, taking a quick look at the diff, It seems this is reverting a few changes that got added recently, can you please check?

Also we recently added a way to do styling using a CSS file, this seems like a better approach to keep the style / html separate.

Can you check if the style.css file that was added fits your needs?

Thanks again!

@Abhilash42069
Copy link
Contributor Author

Abhilash42069 commented Mar 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants