Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internationalisation and Japanese translations #1345

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

rhodricusack
Copy link
Contributor

Further small pieces of internationalisation and Japanese translation.

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rhodricusack
Copy link
Contributor Author

@okaycj Is there anything I can do to help with this and the other three requests #1342 #1343 #1344?

Copy link
Contributor

@okaycj okaycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@rhodricusack
Copy link
Contributor Author

Thank you!

Copy link
Contributor

@okaycj okaycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for backing out of the approved review. Should be just the one change.

web/templates/web/resources.html Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@okaycj okaycj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for the update.

@okaycj okaycj merged commit 6197056 into lookit:develop Mar 14, 2024
1 check passed
okaycj added a commit that referenced this pull request Mar 27, 2024
* Change default exit URL to CHS domain (#1353)

* change default exit_url in Study model to use BASE_URL
* add makemigrations to make file
* switch exit URL from static to reverse
* switch make target from migrations to makemigrations

* Send all emails from same MIT domain and move lab email to reply-to (#1357)

* remove the send_mail "from_email" arg and move lab emails into reply-to
* update and add tests

* Updated jspsych urls (#1360)

* How we added One-click unsubscribe to emails (#1349)

* Add email base templates to hold links

* Update existing templates with new base

* Add new view to unsubscribe

* Update existing tests

* Add test for new view

* Add token generator/check to user model

* Replace sign in link with one click link

* Add new view to post unsubscribe

* Add one click unsubscribe link to email template

* Cover case where user is already unsubscribed.

* Remove unused template

* Update tests

* one-click unsubscribe header

* Fixed more tests

* internationalisation and Japanese translations (#1345)

* internationalisation and Japanese translations

* Remove html tags in response to reviewer request

* Remove html tags in response to reviewer request

* MBAH linting fix (#1369)

* Fix linting issues introduced by merging in mbah PRs

* Add no-root to poetry install command

* Add questions/feedback link to participant emails (#1368)

* Add questions/feedback link to participant emails

* Update tests

* Add CHS to unsubscribe email footer

* Update tests

* Add CHS to "email preferences" footer

* Update links to lookit's unpkg packages (#1370)

* move email footer links to new lines (#1372)

* move email footer links to new lines
* fix test

---------

Co-authored-by: Becky Gilbert <beckyannegilbert@gmail.com>
Co-authored-by: Rhodri Cusack <rhodricusack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants