Conversation
d68e445 to
fe9cc10
Compare
fe9cc10 to
b9f29e5
Compare
|
CI check should pass after merging #539 |
|
@aaqilniz can you please rebase this PR ? |
183a804 to
5d4d5c5
Compare
|
Hi, @samarpanB. The tests are still failing. |
|
@aaqilniz I did the same changes in a new PR #541 and it seemed to be clearing the checks. Can you try by creating a fresh new PR ? Or since you are now part of maintainers you can raise a PR in a new branch here itself without forking the repo. Try that. It seems something is wrong with github action on this PR or on this fork. |
|
Hi, @samarpanB. I created a new PR (with the forked one) but it still fails. I tried pushing a new branch at the original branch (not the forked one), but the request failed with the permission denied error. |
|
@aaqilniz rebase once more please, so that we can check if the CI action passes now. |
6ec9b18 to
b4512d3
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
b4512d3 to
447e0ca
Compare
|
Hi, @samarpanB. The tests are finally passing. Thanks for the help. |
|
Hi, @dhmlau. The tests are finally passing for this PR too. Can you please have a look at the PR please? |
lb4 discoverdoesn't handle enum properly. This PR implements this workaround for the enum inlb4 discover. For that to work, MySQL connector needs to return theenumtype as it is.Related GitHub issues & PRs:
PR loopbackio/loopback-next#10065
Checklist
npm testpasses on your machine