-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of SQLite3 connector #1
Conversation
@slnode test please |
** This connector is based on postgresql connector * Remove tests for unimplemented features * Remove postgres related files * Update tests to use sqlite3 format
LGTM |
The tests are passing on CI, but this is in the console:
|
@rmg I am using moment to parse and check validity of the date being passed in. Do you know of a better library for that. I will merge but open an issue to address this. |
Initial implementation of SQLite3 connector
if (!isNaN(value)) | ||
return ' DEFAULT ' + Number(value); | ||
var parsedValue = moment(value); | ||
if (!parsedValue.isValid()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This condition is inverted, which is why the test for an invalid default of '5'
is passing. moment('5')
, new Date('5')
and Date.parse('5')
all return ''Tue, 01 May 2001 07:00:00 GMT'
or 988700400000
in epoch ms.
See #2
** This connector is based on postgresql connector
Connect to https://github.com/strongloop-internal/scrum-nodeops/issues/409