Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Slog Sublogger #6

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix: Slog Sublogger #6

merged 2 commits into from
Aug 30, 2024

Conversation

ShivanshVij
Copy link
Member

@ShivanshVij ShivanshVij commented Aug 30, 2024 •
edited
Loading

This PR also renames the Logger type to RootLogger and the SubLogger type to Logger for easier use in libraries.

@ShivanshVij
Fixing slog sublogger and adding comprehensive test cases
44869e3 
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij
Renaming SubLogger to Logger and original Logger to RootLogger
be570e7 
Signed-off-by: Shivansh Vij <shivanshvij@loopholelabs.io>
@ShivanshVij ShivanshVij requested review from lgfa29 and pojntfx August 30, 2024 21:37
pojntfx
pojntfx approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@pojntfx pojntfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice that we also have tests for all of this now ^^

@ShivanshVij ShivanshVij merged commit ef47fb8 into main Aug 30, 2024
2 checks passed
@ShivanshVij ShivanshVij deleted the fix-slog-sublogger branch August 30, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pojntfx pojntfx pojntfx approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShivanshVij @pojntfx