feat: Add ability to pretty print json #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesLoot
approved these changes
Nov 5, 2025
Contributor
JohannesLoot
left a comment
JohannesLoot
left a comment
There was a problem hiding this comment.
I like you ❤️
Thank you :)
I approve!
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to pretty print JSON in request and response bodies for improved readability in logs, while also restoring log obfuscation that was previously disabled. The implementation provides a configurable option (prettifyJson) to format JSON with indentation when logging HTTP traffic.
Key changes:
- Added
prettifyJsonconfiguration flag with corresponding UI controls - Implemented JSON prettification logic with fallback for both NewtonSoft.Json and alternative JSON libraries
- Re-enabled log obfuscation in HTTP request/response logging and export functionality
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Runtime/Game/Resources/LootLockerConfig.cs | Added prettifyJson config field and obfuscateLogs field, updated initialization methods |
| Runtime/Game/LootLockerLogger.cs | Implemented obfuscation and prettification pipeline for logged JSON bodies |
| Runtime/Editor/ProjectSettings.cs | Added UI control for the JSON prettification toggle |
| Runtime/Editor/LogViewer/LootLockerLogViewerUI.cs | Updated log viewer to use obfuscation in exports and created JSON foldout UI component |
| Runtime/Client/LootLockerJson.cs | Added PrettifyJsonString method for both JSON serialization backends |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kirre-bylund
force-pushed
the
feat/pretty-print-json
branch
from
7242e25 to
e7f67a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build ability to pretty print json request and response bodies
Also re-add obfuscation that I'd accidentally disabled in my HTTP Queue refactor >.<